Add 'local' to list of logging drivers that support docker-compose logs
#7425
Conversation
…ogs` Signed-off-by: Mike Zak <feanorr@gmail.com>
| @@ -193,7 +193,7 @@ def log_driver(self): | |||
| @property | |||
| def has_api_logs(self): | |||
| log_type = self.log_driver | |||
| return not log_type or log_type in ('json-file', 'journald') | |||
| return not log_type or log_type in ('json-file', 'journald', 'local') | |||
There was a problem hiding this comment.
Slightly related; looks like the description here also needs updating;
Line 211 in 4bc1cbc
There was a problem hiding this comment.
Thanks for the tip. Updated the comment.
Signed-off-by: Mike Zak <feanorr@gmail.com>
|
Will this also fix #7408 ? |
|
Hey, can this PR be merged and new compose version released with the fix? |
|
Thanks for the merge! Is there any information when it is going to be released in a new version? |
|
Not sure when the next release will be (@rumpl may know if something is planned already). Just a heads up; the next Docker (20.xx) release will include a feature called "dual logging" (docs: https://docs.docker.com/config/containers/logging/dual-logging/) that was previously only in the Enterprise Edition of the Docker Engine. That feature has been upstreamed (through moby/moby#40543). With that feature, the "local" logging driver can be always enabled, which means that the |
Resolves #7420